Loading default parameters into class during initialization #466
Conversation
…cConsumerType() and MedShockConsumerType()
sbenthall
changed the title
|
This pull request is now ready for review. Requested from @MridulS |
| @@ -965,7 +966,7 @@ class GenIncProcessConsumerType(IndShockConsumerType): | |||
| solution_terminal_ = ConsumerSolution(cFunc=cFunc_terminal_, mNrmMin=0.0, hNrm=0.0, MPCmin=1.0, MPCmax=1.0) | |||
| poststate_vars_ = ['aLvlNow', 'pLvlNow'] | |||
|
|
|||
| def __init__(self, cycles=1, time_flow=True, **kwds): | |||
| def __init__(self, cycles=0, time_flow=True, **kwds): | |||
There was a problem hiding this comment.
is there a reason for this switch?
| @@ -509,7 +510,7 @@ class MedShockConsumerType(PersistentShockConsumerType): | |||
| ''' | |||
| shock_vars_ = PersistentShockConsumerType.shock_vars_ + ['MedShkNow'] | |||
|
|
|||
| def __init__(self,cycles=1,time_flow=True,**kwds): | |||
| def __init__(self,cycles=0,time_flow=True,**kwds): | |||
|
|
||
| # Make a dictionary for the "explicit permanent income" idiosyncratic shocks model | ||
| init_explicit_perm_inc = copy(init_idiosyncratic_shocks) | ||
| init_explicit_perm_inc['pLvlPctiles'] = pLvlPctiles | ||
| init_explicit_perm_inc['PermGroFac'] = [1.0] # long run permanent income growth doesn't work yet | ||
| init_explicit_perm_inc['cycles'] = cycles |
There was a problem hiding this comment.
probably I am missing something here but why these changes?
|
Can you trace back to the PR where the changes were made? Looks to me as though the default is being changed from finite to infinite horizon models. It should have been infinite horizon all along, so if that is what is being done it make sense -- puzzle is why it wasn't infinite horizon all along. |
|
@MridulS Those changes were made because:
As @llorracc says, the infinite horizon was being passed through to override the finite horizon anyway. So I made the call that this is set properly in the @llorracc : I think you may be responded to comments on PR's in email and the lack of context is confusing. The subject line of the email notification names the PR where this discussion is happening. It should say "#466" |
|
Ok to merge #466? |
This PR is for progress on #446 -- parameter management.
One attractive possibility is that each Model class has default parameters that can be overridden during initialization.
Commit 5c6afef models a way to do this with minimal change to the library for
PerfForesightConsumerType:PerfForesightConsumerTypeinitializationupdate()ed with the keyword arguments to the initializeIn other work on this issue, I'll set this up for the other Model/Type classes. I wanted to put this early PR version out there because I wonder if others think this is a good change.