Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calc expectation #884

Merged
merged 11 commits into from
Dec 15, 2020
Merged

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Dec 15, 2020

Work from #720 rebased onto master. Supersedes #720

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

mnwhite and others added 6 commits December 15, 2020 12:31
Wrote first version of non-symbol expectation-evaluating function, completely untested.  Also fixed a couple typos in distribution.py.
Still need to test alternate input versions.
calcExpectations now tested on more advanced cases.  Fixed dumb typo (copy-pasted from other line) and changed colons to ellipses in axis-construction step.

Also wrote new version of ConsAggShock solver that uses calcExpectation, as a demonstration of what the code would look like.
calcExpectation now correctly handles passing a null argument (empty list) for values, representing a function with no deterministic arguments.
dstn is now first
@project-bot project-bot bot added this to Needs Triage in Issues & PRs Dec 15, 2020
@sbenthall sbenthall merged commit ccb45f3 into econ-ark:calcExpectation Dec 15, 2020
Issues & PRs automation moved this from Needs Triage to Done Dec 15, 2020
@sbenthall
Copy link
Contributor Author

Oh no. I royally messed up this merge attempt and managed to not actually get in the changes from #720! Argh. I will rework this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants