Calc expectation #884
Merged
Calc expectation #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote first version of non-symbol expectation-evaluating function, completely untested. Also fixed a couple typos in distribution.py.
Still need to test alternate input versions.
calcExpectations now tested on more advanced cases. Fixed dumb typo (copy-pasted from other line) and changed colons to ellipses in axis-construction step. Also wrote new version of ConsAggShock solver that uses calcExpectation, as a demonstration of what the code would look like.
calcExpectation now correctly handles passing a null argument (empty list) for values, representing a function with no deterministic arguments.
dstn is now first
|
Oh no. I royally messed up this merge attempt and managed to not actually get in the changes from #720! Argh. I will rework this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work from #720 rebased onto
master. Supersedes #720