Fix type-related bug in DCEGM #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not updated the change-log because I'm not sure what the next release will be and what format you'd like to have (no changes have been recorded since 0.11). |
|
Let's assume that there will be a 0.12.0 release with data TBD |
|
Is this the same thing as #988 looks like it? |
It is, yes. Any of the two solutions should work. |
|
Changelog updated. This is now ready to merge (Alan's solution would also work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of numpy became more strict with respect to data types. Particularly, np.NaN is no longer accepted in integer arrays. This was causing a crash in the DCEGM code whenever it was used with numpy 1.2.0 (which the binder instances do). For instance the DCEGM DemArk binder link crashes.
This PR fixes the issue.