Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building with clang on OS X #55

Closed
taion opened this issue May 2, 2015 · 3 comments
Closed

Building with clang on OS X #55

taion opened this issue May 2, 2015 · 3 comments
Labels
bug
Milestone
v0.3.1

Comments

@taion
Copy link

taion commented May 2, 2015

I can build successfully with gcc on Linux, but I get errors when building with clang on OS X. I see that the installation instructions mention clang; is building with clang known to work?
@taion
Copy link
Author

taion commented May 2, 2015

I'd be happy to send in a PR to fix the clang build issues I'm seeing, but I want to make sure it's not a mistake on my side first.

@ecorm
Copy link
Owner

ecorm commented May 2, 2015

I have never attempted to build with clang, even on Linux. Feel free to submit a PR.

If you get stuck trying to fix it for clang, please attach a log file of the build output, and I'll take a look. Use make VERBOSE=1 to get more verbose build output.

@ecorm ecorm added the bug label May 2, 2015
@taion
Copy link
Author

taion commented May 2, 2015

No big changes required. Doing this for my own benefit as much as anything else. Mostly working around clang bugs/quirks.

Almost done except for some stupid stuff with the std::vector<bool> specialization that's ruining my day.

taion pushed a commit to taion/cppwamp that referenced this issue May 4, 2015
Minor fixes to enable building with clang on OS X
4cb507b 
For ecorm#55
This was referenced May 4, 2015
Closed
Merged
@ecorm ecorm closed this as completed in 6e05dff May 6, 2015
@ecorm ecorm added this to the v0.3.1 milestone May 6, 2015
@ecorm ecorm mentioned this issue May 8, 2015
Closed
ecorm added a commit that referenced this issue May 12, 2015
@ecorm
Fixes and additional tests.
74dfe5c 
- Added as many test cases as possible for supported advanced WAMP features. Some features cannot be tested because they are not supported on Crossbar, or they are not "symmetrically" supported on CppWAMP (closes #43).
- Added test cases where asynchronous Session operations are executed within call/event slots (closes #44).
- Made changes to allow building with Clang on OS X (thanks taion!) (fixes #55).
- Added test case for constructing Variant from std::vector (closes #58).
- Rpc, Procedure, Pub, Topic, and friends now have converting (implicit) constructors (closes #60).
- NaN and infinite Real values are now encoded as null over JSON (fixes #61).
- Fixed unpackedEvent and unpackedRpc so that they can take a lambda functions by value.
- Reorganized wamptest.cpp so that related test cases are grouped in SCENARIO blocks. The Crossbar router process can no longer be forked from the test suite because of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.1
Development

No branches or pull requests
2 participants
@taion @ecorm