Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate Ugly Constructor Hack #29

Closed
ecowden opened this issue Jan 29, 2017 · 1 comment
Closed

Eliminate Ugly Constructor Hack #29

ecowden opened this issue Jan 29, 2017 · 1 comment
Assignees
@ecowden
Labels
enhancement
Milestone
v1.0

Comments

@ecowden
Copy link
Owner

ecowden commented Jan 29, 2017

Back when I originally made this, I was targeting browsers and Node.js v0.8.x. (Also, it's about the first thing I ever wrote in JavaScript.) Dynamically invoking constructor functions was black magic, so I relied on a big ol' switch statement.

Nowadays, this should be easier to work around.
@ecowden ecowden added this to the v1.0 milestone Jan 29, 2017
@ecowden ecowden self-assigned this Jan 29, 2017
ecowden pushed a commit that referenced this issue Jan 29, 2017
Eliminates ugly constructor hack. Fixes #29
40249fb
@ecowden
Copy link
Owner Author

ecowden commented Jan 29, 2017

Fixed on one-oh-redesign branch.

@ecowden ecowden closed this as completed Jan 29, 2017
@ecowden ecowden mentioned this issue Jan 29, 2017
Merged
ecowden added a commit that referenced this issue Feb 4, 2017
@ecowden
v1.0 Redesign (#30)
6426cb9 
Fixes #15, fixes #25, fixes #26, fixes #27, fixes #28, fixes #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecowden ecowden

Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@ecowden