v1.0 Redesign #30
Merged
v1.0 Redesign #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
January 29, 2017 09:35
mikemcbride
reviewed
Jan 30, 2017
README.md
Outdated
|
|
||
| By default, Pluto will only create your objects lazily. That is, factory and constructor functions will only get called | ||
| when you ask for them with `module.get(...)`. | ||
| Invoke `.eagerlyLoadAll()` after creating your bindings to eagerly bootstrap your application. The result is a promise which resolves to a `Map` holding all bindings by name, fully resolved and injected. |
There was a problem hiding this comment.
should this be "Invoke .bootstrap()", based on the example below?
There was a problem hiding this comment.
D'oh! Good catch! I'll fix that this evening.
Keep 'em coming!
|
cc: @squarejaw |
squarejaw
reviewed
Jan 30, 2017
lib/pluto.js
Outdated
| return instance | ||
| } else { | ||
| return Promise.resolve(instance) | ||
| } |
There was a problem hiding this comment.
I think you can just return Promise.resolve(instance) without having to check if it's a promise or not.
|
@mmcbride1007 @squarejaw both good catches. Thanks! Updates made. |
|
Heads up: I'll probably merge this Saturday and move on to pluto-path v1.0. Feel free to add more comments; or toss in additional PRs; or jump over to pluto-path. Issues, feedback, code, and feature requests welcome! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had a few years to think about it, and there's some improvements I've wanted to make for a while. This requires breaking changes to the API, so I think we can call this Pluto v1.0.
Big ones:
...and some clean up:
/cc @cvharris @charwking @mmcbride1007 @marcDeSantis @gehbauerct @durp @adubbs