New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 Redesign #30
Merged
Merged
v1.0 Redesign #30
Changes from 17 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7c94e8c
BREAKS TESTS with new API sketch
db17f2a
makes original tests pass
a359c36
improves async examples; fixes async bug
e873d33
adds additional tests for async cases
a639662
converts string concatenation to use template strings
8818c66
implements the new .eageryLoadAll()
4dcaee7
updates version; fixes eslint dependency
bc73a31
removes underscore type detection in favor of built-in approaches
69b9b1c
removes underscore dependency
723f537
adds strict mode to pluto.js
40249fb
Eliminates ugly constructor hack. Fixes #29
5f47943
fixes linting
e2f7f01
resolves promises that create factory functions
da74484
if a constructor is bound to a promise, resolves the promise first
f2c2088
updates docs
f424c8f
renames eagerlyLoadAll to bootstrap
02974a3
removes 'module' from README
4a49dbf
fixes missed reference to eagerlyLoadAll() that should be bootstrap()
c8253bc
streamlines unnecessary promise check with Promise.resolve(...)
1acf08f
checks for error handling; removes unnecessary code
5429e85
fixes linting
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "Invoke
.bootstrap()
", based on the example below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! Good catch! I'll fix that this evening.
Keep 'em coming!