This repository has been archived by the owner on Feb 20, 2024. It is now read-only.
Destory the element and reset the Stripe object #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam3d
approved these changes
Sep 16, 2017
There was a problem hiding this comment.
Awesome, thank you for doing this! This is the recommended way to destroy components in Vue.
Any updates on this @nkoehring?
nkoehring
approved these changes
Sep 20, 2017
softbeehive
reviewed
Oct 9, 2017
There was a problem hiding this comment.
@jasonlfunk thank you for your contribution! Could you also update package.json version to 0.2.3?
| export function destroy() { | ||
| Stripe.instance = null; | ||
| Stripe.elements = null; | ||
| Stripe.createToken = null; |
There was a problem hiding this comment.
Can you remove semicolons?
| @@ -26,6 +26,8 @@ export default { | |||
|
|
|||
| beforeDestroy () { | |||
| this._element.unmount() | |||
| this._element.destroy() | |||
| destroy(); | |||
There was a problem hiding this comment.
Please remove semicolon
|
Is this supposed to work when hot reloading? |
|
This is the solution for Angular 2+ :
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code makes the code destroy the element and reset the Stripe object when the element is unloaded.
The destroy() is needed to prevent the "IntegrationError: Can only create one Element of type card".
Resetting the Stripe object is necessary to have Stripe re-initialized on the next component mount. This is necessary in order to load remote fonts (and probably other reasons as well.)
This PR isn't throughly tested but it is working fine in my environment.