Support correct postal code events. #25
Conversation
|
@paulpdaniels, thank you for your contribution. It looks good, the only thing I worry in this particular case is backward compatibility. |
| @complete='$emit("complete")' | ||
| @brand='$emit("brand", $event)' | ||
| @error='$emit("error", $event)' | ||
| @value='$emit("value", $event)' |
There was a problem hiding this comment.
@nkoehring, do you remember why does PostalCode.vue contain there listeners?
@complete='$emit("complete")'
@brand='$emit("brand", $event)'
@error='$emit("error", $event)'
@value='$emit("value", $event)'
I like the idea of replacing them with single @change but not sure if it is safe for those who will update the module
There was a problem hiding this comment.
@softbeehive this was just to bring them inline with the other components, which all use the same change event. Based on the commit message it seemed like they all used to have multiple events and this one was just missed?
There was a problem hiding this comment.
that's what it seems to me too, will test it and release if all good
There was a problem hiding this comment.
I remembered I could check git logs too. This looks like where they got out of sync. 5218fbc#diff-25d902c24283ab8cfbac54dfa101ad31
@nkoehring @softbeehive
Expose StripeElement for additional customization.
Fixes #24