Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose MaterialSymbolWeight, SymbolCodepoints interfaces #87

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

tpict
Copy link
Contributor

@tpict tpict commented Feb 21, 2024

Hi and thanks for the library. I'm working a project that has a dependency on react-material-symbols, and we're switching to ES modules.

Previously, we could do something like

import { SymbolCodepoints } from "react-material-symbols/dist/types";

but not anymore. I tried doing

import { MaterialSymbolProps } from "react-material-symbols";

export type SymbolCodepoints = MaterialSymbolProps["icon"]

but the resultant type is any strangely, maybe because of the sheer size of the union? I've opened this PR so you can get at these types directly.

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-material-symbols ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 6:59pm

@ed-software ed-software merged commit 7858ea3 into ed-software:main Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants