Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to latest version of pylint and fix runtime bug #25

Merged
merged 7 commits into from
May 24, 2021
Merged

Switch to latest version of pylint and fix runtime bug #25

merged 7 commits into from
May 24, 2021

Conversation

DavidPal
Copy link
Contributor

@DavidPal DavidPal commented May 23, 2021

This PR fixes issues:

List of changes:

  • Fix runtime version check, which is causing error in the latest versions of pylint.
  • Increase version number to 0.2.2
  • Fix order of imports to make isort happy

Testing:

  • I have created a simple python file x.py with content:
A = "x"
B = 'y'

C = """hello
world
"""

D = '''
hello world
'''

def foo():
    '''Foo'''
    pass
  • I have installed the package and its dependencies: pip install --editable .
  • I have run pylint --load-plugins=pylint_quotes x.py

I have tried tried running unit tests with make test, but get a lot of identical errors:
TypeError: 'module' object is not callable. The same errors show up in Travis.

Travis builds also fail for Python 3.4 and 3.5.

@DavidPal DavidPal marked this pull request as ready for review May 23, 2021 22:28
@edaniszewski
Copy link
Owner

Thanks for the contribution - this looks great.

I'll merge this in and try to work through the import errors seen in tests. I suspect there was just a change in module naming in pylint so now this is importing a module instead of a function.

@edaniszewski edaniszewski merged commit f84e4ee into edaniszewski:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants