-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Podman engine #160
base: master
Are you sure you want to change the base?
Add Podman engine #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some minor stuff. 👍 No worries if you can't be bothered.
Squashed and merged. Thanks again! I'll leave this open until I get to update the docs for this. The |
A last commit, sorry. |
Also adds an option to configure docker commit args.
With the last update on master, docker/podman commit fail with empty {DOCKER,PODMAN}_COMMIT_OPTS: "docker commit" requires at least 1 and at most 2 arguments. To fix it: diff --git a/engine/docker.sh b/engine/docker.sh index e81832c..6765493 100644 --- a/engine/docker.sh +++ b/engine/docker.sh @@ -229,7 +229,7 @@ function build_image() { _container_mount_portage='false' _status_msg="commit ${run_id} as image ${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" - pwrap 'nolog' "${DOCKER}" commit "${DOCKER_COMMIT_OPTS}" "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \ + pwrap 'nolog' "${DOCKER}" commit ${DOCKER_COMMIT_OPTS} "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \ || die "${_status_msg}" |
My bad, somewhat blindly fixed the shellcheck error for that. Fixed. |
>=libpod-1.8.0 now supports the -f argument for image prune
PR related to #159