fix(popup): Fixed conflict with BrowserAnimationsModule (#234)

* fix(popup): Fixed conflict with BrowserAnimationsModule Closes #204 * style(popup): Fixed tslint error
edcarroll · Aug 11, 2017 · 5f8d6cb · 5f8d6cb
1 parent f6101d9
commit 5f8d6cb
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/modules/popup/classes/popup-controller.ts b/src/modules/popup/classes/popup-controller.ts
@@ -65,8 +65,7 @@ export abstract class SuiPopupController implements IPopup, OnDestroy {
             });
         }
 
-        // Detach & reattach the generated component to the current application.
-        this._componentFactory.detachFromApplication(this._componentRef);
+        // Attach the generated component to the current application.
         this._componentFactory.attachToApplication(this._componentRef);
 
         // Move the generated element to the body to avoid any positioning issues.
@@ -151,7 +150,6 @@ export abstract class SuiPopupController implements IPopup, OnDestroy {
         }
     }
 
-    // @HostListener("document:click", ["$event"])
     public onDocumentClick(e:MouseEvent):void {
         // If the popup trigger is outside click,
         if (this._componentRef && this.popup.config.trigger === PopupTrigger.OutsideClick) {
@@ -179,6 +177,7 @@ export abstract class SuiPopupController implements IPopup, OnDestroy {
 
     public ngOnDestroy():void {
         clearTimeout(this._openingTimeout);
+        this._componentFactory.detachFromApplication(this._componentRef);
         this._componentRef.destroy();
     }
 }