Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuiPopupModule not working at all #204

Closed
sunjoseph opened this issue Jul 31, 2017 · 12 comments
Closed

SuiPopupModule not working at all #204

sunjoseph opened this issue Jul 31, 2017 · 12 comments
Assignees
@edcarroll
Labels
comp: popup priority: important type: bug
Milestone
0.9.5

Comments

@sunjoseph
Copy link

I'm integrating modal popup into my website, other modules work link charm, but this.
It doesn't pop template event hover like basic example below:



Hope you can help me.
Thanks in advantage.
@edcarroll
Copy link
Owner

Hi, please could you post a reproduction on Plunkr so I can investigate this further? Currently there isn't anything I can go on.

@edcarroll edcarroll self-assigned this Jul 31, 2017
@namzee2013
Copy link

namzee2013 commented Aug 3, 2017 •
edited
Loading

Seems this was conflicted with BrowserAnimationsModule module

@edcarroll
Copy link
Owner

edcarroll commented Aug 3, 2017 •
edited
Loading

@namzee2013 hmmm this has happened before. This must be to do with how the BrowserAnimationsModule controls the transition CSS property, as the library itself doesn't use that module at all. Are you able to set up a plunkr so I can investigate a bit further please?

@namzee2013
Copy link

@edcarroll
Please check this link https://plnkr.co/edit/eGsNmlbf9x1l83ZNzsLY?p=preview :)

@edcarroll
Copy link
Owner

@namzee2013 thank you for the plunkr 🎉 will take a look at this properly when I get some time.

@edcarroll edcarroll added this to the 0.9.5 milestone Aug 4, 2017
@jmls
Copy link

jmls commented Aug 7, 2017

ah - I think I just hit this as well ... any workarounds ?

edcarroll added a commit that referenced this issue Aug 11, 2017
@edcarroll
fix(popup): Fixed conflict with BrowserAnimationsModule
b09a615 
Closes #204
@edcarroll edcarroll mentioned this issue Aug 11, 2017
Merged
@edcarroll
Copy link
Owner

This was a fun one! This was (somehow) due to the fact that the generated popup component was previously being detached and reattached on open - I've moved the detach to the destroy and close methods and things seem fine now.

Will put this fix out in the next release 😄

mcosta74 pushed a commit that referenced this issue Aug 11, 2017
@edcarroll @mcosta74
fix(popup): Fixed conflict with BrowserAnimationsModule (#234)
5f8d6cb 
* fix(popup): Fixed conflict with BrowserAnimationsModule

Closes #204

* style(popup): Fixed tslint error
mcosta74 pushed a commit that referenced this issue Aug 14, 2017
@edcarroll @mcosta74
fix: Fixed AOT on SystemJS builder (#240)
a8f0f47 
* fix: Fixed AOT on SystemJS builder

Closes #209

* fix: Added custom FocusEvent interface (#231)

* fix: Added custom FocusEvent interface

Closes #202

FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need.

* style(util): Fixed tslint error

* chore(popup): Relaxed popper.js dependency (#228)

Follows up on #195

* fix(popup): Fixed delay causing destroyed view errors (#233)

Closes #189

* fix(select): Manually run change detector when option updates (#236)

* fix(select): Manually run change detector when option updates

Closes #213

* style(select): Fixed tslint error

* fix(select): Selected options now updated when options change (#232)

* fix(modal): Fixed aggressive autofocus sometimes causing errors (#237)

* fix(popup): Fixed conflict with BrowserAnimationsModule (#234)

* fix(popup): Fixed conflict with BrowserAnimationsModule

Closes #204

* style(popup): Fixed tslint error

* feat(popup): Added template context support (#238)

* fix(popup): Fixed focus events on popup (#243)

* feat(datepicker) Popup now honors locale and pickerLocaleOverrides (#215)

* Datepicker popup now honors locale and pickerLocaleOverrides

- Datepicker popup items now respect locale format
- Fixed a bug in zoom calendar mapping for datetime datepicker
- Fixed 'es' locale for consistency

(*) Partially addresses #164

* Added comments.

* Time of day values supported in locale definitions (#214)

* en-GB and en-US locales now use 12 hour format

Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.)

* Fix locales Russian, Italian and Hebrew now extend from ILocaleValues.

* Added new IDatepickerFormatsLocaleValues fields:
- timesOfDay
- timesOfDayUppercase
- timesOfDayLowercase
to support proper formatting/parsing of dates in datepicker.

Updated Localization page

* Fixing code formatting

* feat(datepicker) Added initial date support for the datepicker (#216)

* feat(datepicker) New input pickerInitialDate

- New input (optional) that sets the intial date to display (null = today)
- Updated demo page

Partially addresses #165

* Now pickerInitialDate only sets CalendarService.currentDate property

* feat(datepicker): Initial date support
- Code formatting

* fix: Various minor bugfixes (#245)

* fix(select): Fixed destroyed view errors

* fix(modal): Fix modal auto closing when clicked

* fix(popup): Removed console log in focus handler

* fix(popup): Forced import of TemplateRef

* fix: Fixed AOT on SystemJS builder

Closes #209
@edcarroll
Copy link
Owner

This is now live in 0.9.5. Let me know if you have any further issues 😄

gotenxds pushed a commit to gotenxds/ng2-semantic-ui that referenced this issue Aug 15, 2017
@edcarroll @gotenxds
fix(popup): Fixed conflict with BrowserAnimationsModule (edcarroll#234)
ee4dcce 
* fix(popup): Fixed conflict with BrowserAnimationsModule

Closes edcarroll#204

* style(popup): Fixed tslint error
gotenxds pushed a commit to gotenxds/ng2-semantic-ui that referenced this issue Aug 15, 2017
@edcarroll @gotenxds
fix: Fixed AOT on SystemJS builder (edcarroll#240)
9636461 
* fix: Fixed AOT on SystemJS builder

Closes edcarroll#209

* fix: Added custom FocusEvent interface (edcarroll#231)

* fix: Added custom FocusEvent interface

Closes edcarroll#202

FocusEvent isn't defined in UC browser, so added IFocusEvent with the property we need.

* style(util): Fixed tslint error

* chore(popup): Relaxed popper.js dependency (edcarroll#228)

Follows up on edcarroll#195

* fix(popup): Fixed delay causing destroyed view errors (edcarroll#233)

Closes edcarroll#189

* fix(select): Manually run change detector when option updates (edcarroll#236)

* fix(select): Manually run change detector when option updates

Closes edcarroll#213

* style(select): Fixed tslint error

* fix(select): Selected options now updated when options change (edcarroll#232)

* fix(modal): Fixed aggressive autofocus sometimes causing errors (edcarroll#237)

* fix(popup): Fixed conflict with BrowserAnimationsModule (edcarroll#234)

* fix(popup): Fixed conflict with BrowserAnimationsModule

Closes edcarroll#204

* style(popup): Fixed tslint error

* feat(popup): Added template context support (edcarroll#238)

* fix(popup): Fixed focus events on popup (edcarroll#243)

* feat(datepicker) Popup now honors locale and pickerLocaleOverrides (edcarroll#215)

* Datepicker popup now honors locale and pickerLocaleOverrides

- Datepicker popup items now respect locale format
- Fixed a bug in zoom calendar mapping for datetime datepicker
- Fixed 'es' locale for consistency

(*) Partially addresses edcarroll#164

* Added comments.

* Time of day values supported in locale definitions (edcarroll#214)

* en-GB and en-US locales now use 12 hour format

Original "HH:mm" (23:59) -> Now "hh:mm aa" (11:59 p.m.)

* Fix locales Russian, Italian and Hebrew now extend from ILocaleValues.

* Added new IDatepickerFormatsLocaleValues fields:
- timesOfDay
- timesOfDayUppercase
- timesOfDayLowercase
to support proper formatting/parsing of dates in datepicker.

Updated Localization page

* Fixing code formatting

* feat(datepicker) Added initial date support for the datepicker (edcarroll#216)

* feat(datepicker) New input pickerInitialDate

- New input (optional) that sets the intial date to display (null = today)
- Updated demo page

Partially addresses edcarroll#165

* Now pickerInitialDate only sets CalendarService.currentDate property

* feat(datepicker): Initial date support
- Code formatting

* fix: Various minor bugfixes (edcarroll#245)

* fix(select): Fixed destroyed view errors

* fix(modal): Fix modal auto closing when clicked

* fix(popup): Removed console log in focus handler

* fix(popup): Forced import of TemplateRef

* fix: Fixed AOT on SystemJS builder

Closes edcarroll#209
@preethis610
Copy link

SuiPopupModule not working at all

@edcarroll
Copy link
Owner

@preethis610 as above this is now fixed, upgrade to 0.9.5 😄

@edcarroll edcarroll mentioned this issue Aug 17, 2017
Closed
@preethis610
Copy link

In 0.9.5 it is working...Thank you

@charlenebuena
Copy link

Updating ng2-semantic-ui to 0.9.5 also updates its dependency popper.js to the latest version that would later on produce error "Cannot find namespace 'Popper"

popper.js@1.14.1 didn't work for me
popper.js@1.12.9 worked for me

What I did:
npm install ng2-semantic-ui@0.9.5 popper.js@1.12.9 --save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edcarroll edcarroll

Labels
comp: popup priority: important type: bug
Projects
None yet
Milestone
0.9.5
Development

No branches or pull requests
6 participants
@jmls @sunjoseph @edcarroll @charlenebuena @namzee2013 @preethis610