Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parsing for negative nanoperiod #96

Closed
lsilvest opened this issue Dec 2, 2021 · 0 comments
Closed

Incorrect parsing for negative nanoperiod #96

lsilvest opened this issue Dec 2, 2021 · 0 comments

Comments

@lsilvest
Copy link
Collaborator

lsilvest commented Dec 2, 2021 

> as.nanoperiod("0d/-00:00:01")
[1] 0m0d/-00:00:01
> as.nanoperiod("00:00:01")
[1] 0m0d/00:00:01
> as.nanoperiod("-00:00:01")
Error in period_from_string_impl(x) : cannot parse nanoperiod

This last one should actually parse exactly like a nanoduration:

> as.nanoduration("-00:00:01")
[1] -00:00:01
eddelbuettel added a commit that referenced this issue Mar 6, 2022
@eddelbuettel
Merge pull request #100 from eddelbuettel/fix_in_operator
15c63c6 
fix %in% and negative 'nanoperiod' parse. closes #96 #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lsilvest