solve the summary issue by defining 'names<-'; fix issue with 'c' #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was enough to define
names<-
in order forsummary.integer64
to work onnanotime
.There was an issue with
c
, it was using the double value ofnanotime
instead of itsinteger64
value. Interestingly, the tests work becausenanotime
is originally a double in disguise. SoRUnit::checkEquals
, which ultimately callsall.equal(target, current, msg="", tolerance = .Machine$double.eps^0.5)
returnsTRUE
when the values are close together. SocheckEquals(nanotime(1), nanotime(2))
returnsTRUE
(and this is the case forinteger64
too). That's annoying, but I think it's the kind of thingnanotime
will have to live with, because at the end of the day, despite its elegance,integer64
is still a hack...