-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More content for RcppAnnoy.h #65
Comments
See #64 for more content regarding prefixing. |
One possible variant (currently in my file) // -- convenience typedefs
// prefixed with Rcpp to ensure we are most unlikely to clash with upstream defines
// usage of these is entire optional
#ifdef ANNOYLIB_MULTITHREADED_BUILD
typedef AnnoyIndexMultiThreadedBuildPolicy RcppAnnoyIndexThreadPolicy;
#else
typedef AnnoyIndexSingleThreadedBuildPolicy RcppAnnoyIndexThreadPolicy;
#endif
typedef Annoy<int32_t, float, Angular, Kiss64Random, RcppAnnoyIndexThreadPolicy> RcppAnnoyAngular;
typedef Annoy<int32_t, float, Euclidean, Kiss64Random, RcppAnnoyIndexThreadPolicy> RcppAnnoyEuclidean;
typedef Annoy<int32_t, float, Manhattan, Kiss64Random, RcppAnnoyIndexThreadPolicy> RcppAnnoyManhattan;
typedef Annoy<int32_t, uint64_t, Hamming, Kiss64Random, RcppAnnoyIndexThreadPolicy> RcppAnnoyHamming; Comments, @LTLA @jlmelville ? Useful? Useless? Other additions? |
Yes, that would help. I'm looking at https://github.com/LTLA/BiocNeighbors/blob/master/src/annoy.h and I can see that I could basically delete lines 5 to 26 and also lines 41-45. Not entirely sure why I needed to define |
Turns out I was too ambitious (and had not tried to compile the above). The |
Per discussion in #64 we may as well add both these, no?
Comments, @LTLA @jlmelville ? Useful? Useless? Other additions?
The text was updated successfully, but these errors were encountered: