Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
new upstream version 1.13 (plus two PRs from here) #30
Regarding the fix: it's already in the PR, but I imagine it would be preferable for RcppAnnoy's headers to stay consistent with annoy itself, lest confusion arise when other people try to
Regarding the tests: yeah, that's probably a good idea. It's a bit tricky to set up thorough unit tests with methods that are both randomized and approximate... the output's always going to be a little bit wrong.
Oct 9, 2018
I glanced at spotify/annoy#314 / spotify/annoy#315 / spotify/annoy#316. I suspect @erikbern will fold your spotify/annoy#316 in as he is a generally reasonable gentleman (but busy, aren't we all) so maybe we just proceed with folding it here first (unless he beats us to it) ?
No rush as I just created a branch with a pdf variant of your contributed vignette. Let's fold (or discard in case you hated it) that first and then we see what happens with this.