-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xml parsing error occurred trying to get md5 data for .... #63
Comments
I got rid of the error by changing line 360 |
This appeared to correct itself without intervention late yesterday, if someone else can confirm for me (without patching), i will happily close this ticket off
|
Fwiw, I just experienced this issue a few minutes ago (using the Update: With the fix applied, I'm seeing the error message for a small fraction of the downloadable files. Maybe GOG is in the middle of a transition which affects only some downloads/servers? |
Same issue here on Feb 27th. Applied the line edit above, and all seems good again. Thanks :) |
Just checked. Also here, I do need the patch to get rid of the errors. |
Happening for me too. All of my purchased games, without exception, were giving me the error. The patch mentioned in #63 (comment) did correct the error for me. Thanks for your work, all. :) |
A few games were still failing to find the md5 for me with the patch, turns out gog gzip larger game info xmls and it wasn't handled, i've added support and a variation on the patch in my fork now and switched our project across to use that. We also noted thanks to a report on our issues for RetroNAS, sync is completely broken for downloading game files with these xml errors, it'll only sync extras. Originally i'd just figured it was informational since i like output, i've added an info message containing found md5s as well
Control still has/had an issue getting one of its md5s but i dumped out my temp_md5_url and tried to browse and curl it, both were broken, i also gave it a few mins incase generation was slow on gogs end then I was going to add a retry mech, no luck
There may be more in that same boat, i'm going through a full update now |
I can confirm that @TheLateNightFlight's fix isn't total. The following games still report md5 errors using his patch:
Hedon and Star Renegades confuses me, as those are not huge games. Now, I'll try cherry-picking your commit over to my fork and see what happens. After swapping Python 2.7.18 for 3.10.2 because I'm a dumb idiot who both was still running 2.x and can't figure out coexistence, I, too, still have two lingering MD5 errors. I'm not knowledgeable enough to debug the variable like you did, so I'll just presume my error is the same as yours.
|
I have an issue with one file for Control but the md5 page wasn't available when i checked it manually You could add a line after this to print out the I do not own either of those games to test with unfortunately |
Pulling up one of the successful URLs in the browser gives me this:
and here's the curl output:
Interestingly, trying to open the output file in Notepad++ gives me gibberish. The curl for the failing MD5 just sits and spins. It's been spinning for three and a half minutes, and I bet if I let it sit and spin while I go to work, it'll just spin for h o u r s. Edit: No it will not, apparently.
The file does exist in the manifest, and the downloader succeeds in grabbing it, though. Curious. |
I seem to be getting this for nearly every game. Do I need to edit the code as some comments here suggested or is GOG suffering heavy traffic or something? |
Thanks all. GOG changed the URLs for where MD5 XML data is stored. I've pushed a fix for this. |
Looks like gog may have changed something recently. We have received and confirmed reports (as per retronas/retronas#117) of our users getting xml parsing errors during manifest refresh from this tool.
The text was updated successfully, but these errors were encountered: