Swapped out getheader to headers.get so the script does not error when getting the games xml file #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n getting the games xml file
|
What version of python was this run against when it failed? |
|
2.7.15 and it was this doc I used as the basis for the change: https://docs.python-requests.org/en/latest/user/quickstart/#response-headers Note: I'm not sure if the script is using this module or not, the documentaiton appears to match... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason I could not get this script to work in its orignal form.
I'm not a python dev so I don't know of the best way to do this or even if this PR is done correctly. For whatever it is worth this change allowed the script to work for me.
I came to be using this script because the original one I was using started failing due to XML parsing bugs: eddie3#63