Allocate guard page under existing stack, not in it #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
changed the title
This fixes a segfault when the allocated stack is just one page long. This also refactors the fringe::os module to use Result consistently.
edef1c
pushed a commit
that referenced
this pull request
Feb 25, 2017
This fixes a segfault when the allocated stack is just one page long. This also refactors the fringe::os module to use Result consistently. close #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a segfault when the allocated stack is just one page long, and adds a test. Allocating a stack one page long was legal according to the documentation and it would be accessible, but what happened is a stack one page long was allocated and that one page was marked as guard page (instead of one page under the entire useful stack area).
This also refactors the fringe::os module to use Result consistently.