Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy coroutines #27

Closed
wants to merge 3 commits into from
Closed

Fancy coroutines #27

wants to merge 3 commits into from

Conversation

Ericson2314
Copy link
Contributor

@Ericson2314 Ericson2314 commented Jul 21, 2016

First commits make internal changes. Final adds new stuff. Everything works but needs to be cleaned and documented---opening this now for feedback during that cleaning and documenting. LMK if leaving out the last commit makes more sense as first step.

CC @whitequark

@whitequark
Copy link
Contributor

@nathan7 So, I've looked at this PR again.

  • It adds 1300 lines of extremely convoluted code whose only significant purpose is to avoid a memcpy.
  • We don't export the unsafe interface at all, anymore.

@Ericson2314
Copy link
Contributor Author

Ericson2314 commented Aug 18, 2016

@whitequark the first part is that's just not true :(. Not sure what you mean by the second. I'll rebase on top of the latest changes.

@edef1c
Copy link
Owner

edef1c commented Feb 15, 2017

(closing this mainly for inactivity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants