Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eraser doesn't erase if you drag it over objects too fast #46

Open
PMKielstra opened this issue Jun 17, 2020 · 5 comments
Open

Eraser doesn't erase if you drag it over objects too fast #46

PMKielstra opened this issue Jun 17, 2020 · 5 comments
Labels
blocked Waiting for another issue to be resolved

Comments

@PMKielstra
Copy link

Draw a line. Select the eraser tool. With the mouse down, move the eraser across the line very quickly. The line is not erased.

@edemaine
Copy link
Owner

edemaine commented Jun 17, 2020

Indeed, currently collision is detected only at the sample points, without any interpolation in between. Linear interpolation would make sense. I'm hoping there's a DOM query for this type of intersection... Likely blocked on #87.

@ni-tro
Copy link

ni-tro commented Nov 3, 2020

+1 on this issue. Using a pen on a tablet, the eraser is even slower.
For me this makes using cocreate a lot more time-consuming and has the effect that I rather use a different tool for scribbling on my own and later recreate the important parts in a shared Cocreate whiteboard...

@edemaine
Copy link
Owner

edemaine commented Nov 3, 2020

A workaround for now is to use the select tool (drag to rectangular select) and then pressing the Delete key. (But that doesn't work on a tablet-only device.)

@edemaine edemaine added the blocked Waiting for another issue to be resolved label Nov 3, 2020
@edemaine
Copy link
Owner

edemaine commented Nov 4, 2020

I just implemented an improvement to the eraser object detection (looking at all coalesced events instead of just the final event in a sequence) that should help — hopefully a lot and perhaps especially when using a pen on a tablet — though there's more that could be done after #87. Let me know if you see improvements in your environment, @ni-tro.

@ndattani
Copy link

ndattani commented Dec 8, 2021

I only started using this within the last month, so your improvement from 1 year ago (mentioned in your last comment) would already have been implemented, but I have a very hard time using the eraser tool! Often it doesn't do anything, and often it's slow (and causes my CPU to start getting overworked). I instead use the select tool to make a rectangle and then press delete, but unfortunately, lots of other objects that I do not want deleted (which are not even in the rectangle!) get deleted along with what's inside the rectangle, which is quite inconvenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting for another issue to be resolved
Projects
None yet
Development

No branches or pull requests

4 participants