Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce final bundle size #293

Merged
merged 2 commits into from
Feb 18, 2021
Merged

reduce final bundle size #293

merged 2 commits into from
Feb 18, 2021

Conversation

adriexnet
Copy link
Contributor

reduce final bundle size

What does this PR do?

Avoid load unused icons from ual-reactjs-renderer to reduce the final bundle size
for more information take a look to EOSIO/ual-reactjs-renderer#103 and EOSIO/ual-reactjs-renderer#105

Steps to test

  1. make run lacchain
  2. navigate to http://localhost:3000/
  3. check the loading time

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adriexnet Please set dependency to EOS Costa Rica's github

webapp/package.json Outdated Show resolved Hide resolved
@xavier506 xavier506 added this to Code Review in EOSIO Network Dashboard Dec 7, 2020
@xavier506 xavier506 self-requested a review January 14, 2021 02:21
@@ -23,6 +23,7 @@
"not op_mini all"
],
"dependencies": {
"@eoscostarica/ual-reactjs-renderer": "^0.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit f0790f9 into dev Feb 18, 2021
EOSIO Network Dashboard automation moved this from Code Review to Done Feb 18, 2021
xavier506 added a commit that referenced this pull request Feb 22, 2021
* Document the wallet configuration proccess and the related hapi
env variables. refs #137

* Document the wallet configuration proccess and the related
hapi env variables. refs #137

* fix typos. refs #137

* fix typos. refs #137

* fix: add missing parameter. refs #137

* reduce final bundle size  (#293)

* chore: avoid load unused icons from ual-reactjs-renderer to reduce the final bundle size

* chore: update eslint config

* feat: add new actions for permissioning committee and entity account (#332)

Co-authored-by: kurono <kurono@riseup.net>
Co-authored-by: adriel <adriexnet@gmail.com>
xavier506 added a commit that referenced this pull request Feb 28, 2021
* Document the wallet configuration proccess and the related hapi
env variables. refs #137

* Document the wallet configuration proccess and the related
hapi env variables. refs #137

* fix typos. refs #137

* fix typos. refs #137

* fix: add missing parameter. refs #137

* reduce final bundle size  (#293)

* chore: avoid load unused icons from ual-reactjs-renderer to reduce the final bundle size

* chore: update eslint config

* feat: add new actions for permissioning committee and entity account (#332)

* Configure a storageclass for the EOSIO dashboard (#338)

* configure a storageclass for the EOSIO dashboard. refs #329

* fix version in storgaeclass. refs #329

* create releasing and versioning workflows. refs #334

* fix typo in action workflow. refs #334

* improvements  (#339)

* feat: add new actions for permissioning committee and entity account

* feat: generate config for new nodes

* chore: update favicon

* fix: missing REACT_APP_USE_CPU_BENCHMARK variable for LACChain

* feat: add cpu beanchmark average

* add link to relase documentation in the readme. refs #334

Co-authored-by: kurono <kurono@riseup.net>
Co-authored-by: adriel <adriexnet@gmail.com>
@xavier506 xavier506 deleted the feature/reduce-bundle-size branch May 11, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants