improvements #339
Merged
improvements #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuronosec
approved these changes
Feb 25, 2021
| REACT_APP_EOS_API_HOST: 'lacchain.eosio.cr' | ||
| REACT_APP_EOS_API_PORT: '443' | ||
| REACT_APP_EOS_API_PROTOCOL: 'https' | ||
| REACT_APP_EOS_CHAIN_ID: '5821525c6588037e2b066b992fcac34909a5b7f1ea8d5a393f6720fca3750d61' |
There was a problem hiding this comment.
@adriexnet what is better: single quotes vs double quotes, and why?
xavier506
added a commit
that referenced
this pull request
Feb 28, 2021
* Document the wallet configuration proccess and the related hapi env variables. refs #137 * Document the wallet configuration proccess and the related hapi env variables. refs #137 * fix typos. refs #137 * fix typos. refs #137 * fix: add missing parameter. refs #137 * reduce final bundle size (#293) * chore: avoid load unused icons from ual-reactjs-renderer to reduce the final bundle size * chore: update eslint config * feat: add new actions for permissioning committee and entity account (#332) * Configure a storageclass for the EOSIO dashboard (#338) * configure a storageclass for the EOSIO dashboard. refs #329 * fix version in storgaeclass. refs #329 * create releasing and versioning workflows. refs #334 * fix typo in action workflow. refs #334 * improvements (#339) * feat: add new actions for permissioning committee and entity account * feat: generate config for new nodes * chore: update favicon * fix: missing REACT_APP_USE_CPU_BENCHMARK variable for LACChain * feat: add cpu beanchmark average * add link to relase documentation in the readme. refs #334 Co-authored-by: kurono <kurono@riseup.net> Co-authored-by: adriel <adriexnet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvements
What does this PR do?
Steps to test
CheckList