fix: Remove explicit check for enabled RPC interface (#143)

* fix: Remove explicit check for enabled RPC interface

* fix: Use new ResponseMismatchError exception

src/citric/exceptions.py

@@ -1,6 +1,10 @@
 """Common exceptions."""
 
 
+class ResponseMismatchError(Exception):
+    """Exception raised when request and response ID don't match."""
+
+
 class LimeSurveyError(Exception):
     """Basic exception raised by LimeSurvey."""
 

src/citric/session.py

@@ -10,6 +10,7 @@
     LimeSurveyError,
     LimeSurveyStatusError,
     LimeSurveyApiError,
+    ResponseMismatchError,
 )
 from citric.method import Method
 
@@ -29,9 +30,6 @@ class Session:
             For example, `AuthLDAP`_. Defaults to using the internal database
             (``"Authdb"``).
 
-    Raises:
-        LimeSurveyError: If the JSON RPC interface is not enabled.
-
     .. _requests.Session:
         https://docs.python-requests.org/en/latest/api/#requests.Session
     .. _plugin: https://manual.limesurvey.org/Authentication_plugins
@@ -65,9 +63,6 @@ def __init__(
             auth_plugin,
         )
 
-        if self.get_site_settings("RPCInterface") != "json":
-            raise LimeSurveyError("JSON RPC interface is not enabled.")
-
         self.__closed = False
 
     @property
@@ -119,7 +114,8 @@ def _invoke(session: requests.Session, url: str, method: str, *params: Any) -> A
             LimeSurveyStatusError: The response key from the response payload has
                 a non-null status.
             LimeSurveyApiError: The response payload has a non-null error key.
-            LimeSurveyError: Request ID does not match the response ID.
+            LimeSurveyError: If the JSON RPC interface is not enabled (empty response).
+            ResponseMismatchError: Request ID does not match the response ID.
 
         Returns:
             Any: An RPC result.
@@ -152,7 +148,7 @@ def _invoke(session: requests.Session, url: str, method: str, *params: Any) -> A
             raise LimeSurveyApiError(error)
 
         if response_id != request_id:
-            raise LimeSurveyError(
+            raise ResponseMismatchError(
                 f"Response ID {response_id} does not match request ID {request_id}",
             )
 

tests/test_rpc.py

@@ -8,6 +8,7 @@
     LimeSurveyApiError,
     LimeSurveyError,
     LimeSurveyStatusError,
+    ResponseMismatchError,
 )
 from citric.method import Method
 from citric.session import Session
@@ -81,17 +82,6 @@ def test_session_context(
         session.closed = False
 
 
-def test_interface_off(
-    url: str,
-    username: str,
-    password: str,
-    off_session: requests.Session,
-):
-    """Test effect of JSON RPC not enabled."""
-    with pytest.raises(LimeSurveyError, match="JSON RPC interface is not enabled"):
-        Session(url, username, password, requests_session=off_session)
-
-
 def test_empty_response(session: Session):
     """Test empty response."""
     with pytest.raises(LimeSurveyError, match="RPC interface not enabled"):
@@ -126,6 +116,6 @@ def randint(a, b):
     monkeypatch.setattr(random, "randint", randint)
 
     with pytest.raises(
-        LimeSurveyError, match="Response ID 2 does not match request ID 123"
+        ResponseMismatchError, match="Response ID 2 does not match request ID 123"
     ):
         session.__bad_id()