Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove explicit check for enabled RPC interface #143

Merged
merged 2 commits into from Jan 28, 2022
Merged

fix: Remove explicit check for enabled RPC interface #143

merged 2 commits into from Jan 28, 2022

Conversation

edgarrmondragon
Copy link
Owner

Closes #142

@edgarrmondragon edgarrmondragon self-assigned this Jan 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022 •
edited

Codecov Report

Merging #143 (36da173) into master (10d8b05) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          197       196    -1     
  Branches        23        23           
=========================================
- Hits           197       196    -1
Impacted Files Coverage Δ
src/citric/exceptions.py 100.00% <100.00%> (ø)
src/citric/session.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d8b05...36da173. Read the comment docs.

@edgarrmondragon edgarrmondragon changed the title Remove explicit check for enabled RPC interface fix: Remove explicit check for enabled RPC interface Jan 28, 2022
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 28, 2022 05:46
@edgarrmondragon edgarrmondragon merged commit 8effb13 into master Jan 28, 2022
@edgarrmondragon edgarrmondragon deleted the 142-do-not-check-rpc branch January 28, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: LimeSurveyStatusError: Invalid setting raised for users without Superadmin permission
2 participants
@edgarrmondragon @codecov-commenter