Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement delete_language in client #208

Merged
merged 3 commits into from Mar 24, 2022
Merged

feat: implement delete_language in client #208

merged 3 commits into from Mar 24, 2022

Conversation

edgarrmondragon
Copy link
Owner

Closes #206

@edgarrmondragon edgarrmondragon added enhancement New feature or request RPC Issues related to the RPC client implementation labels Feb 8, 2022
@edgarrmondragon edgarrmondragon self-assigned this Feb 8, 2022
@edgarrmondragon edgarrmondragon added this to In progress in High-Level Python API Feb 8, 2022
@edgarrmondragon
Copy link
Owner Author

edgarrmondragon commented Feb 8, 2022 •
edited 

______________________________ test_add_language _______________________________

client = <citric.client.Client object at 0x7f5451e88250>, survey_id = 98765

    @pytest.mark.integration_test
    def test_add_language(client: citric.Client, survey_id: int):
        """Test adding a new language to a survey."""
        client.add_language(survey_id, "es")
        client.add_language(survey_id, "ru")
    
        survey_props = client.get_survey_properties(survey_id)
        assert survey_props["additional_languages"] == "es ru"
    
        client.delete_language(survey_id, "ru")
>       assert survey_props["additional_languages"] == "es"
E       AssertionError: assert 'es ru' == 'es'
E         - es
E         + es ru

tests/test_integration.py:77: AssertionError

Failing due to https://bugs.limesurvey.org/view.php?id=17873.

Possible fix in LimeSurvey/LimeSurvey#2235

@edgarrmondragon edgarrmondragon force-pushed the 206-delete-language branch 5 times, most recently from ea41479 to f522fc9 Compare March 14, 2022 18:15
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit 69dc62c into master Mar 24, 2022
High-Level Python API automation moved this from In progress to Done Mar 24, 2022
@edgarrmondragon edgarrmondragon deleted the 206-delete-language branch March 24, 2022 11:29
@edgarrmondragon edgarrmondragon added this to the Full API coverage milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
enhancement New feature or request RPC Issues related to the RPC client implementation
Projects
High-Level Python API
Status: Done
High-Level Python API
  
Done
Milestone
Full API coverage
Development

Successfully merging this pull request may close these issues.

Feature: implement delete_language in client
1 participant
@edgarrmondragon