Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement export_timeline in client #240

Merged
merged 3 commits into from
Feb 17, 2022
Merged

feat: implement export_timeline in client #240

merged 3 commits into from
Feb 17, 2022

Conversation

edgarrmondragon
Copy link
Owner

Closes #238

@edgarrmondragon edgarrmondragon self-assigned this Feb 17, 2022
@edgarrmondragon edgarrmondragon changed the title feat: implement export_timeline in client feat: implement export_timeline in client Feb 17, 2022
@edgarrmondragon edgarrmondragon added RPC Issues related to the RPC client implementation enhancement New feature or request labels Feb 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #240 (d28af92) into master (3cf1b1a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          247       259   +12     
  Branches        29        31    +2     
=========================================
+ Hits           247       259   +12
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)
src/citric/enums.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf1b1a...d28af92. Read the comment docs.

@edgarrmondragon edgarrmondragon merged commit 83340a9 into master Feb 17, 2022
@edgarrmondragon edgarrmondragon deleted the 238-export-timeline branch February 17, 2022 05:54
@edgarrmondragon edgarrmondragon added this to the Full API coverage milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
enhancement New feature or request RPC Issues related to the RPC client implementation
Projects
High-Level Python API
Status: Done
Milestone
Full API coverage
Development

Successfully merging this pull request may close these issues.

Feature: implement export_timeline in client
2 participants
@edgarrmondragon @codecov-commenter