v1.8.1 #129
Merged
v1.8.1 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improves approachability of the code as a whole. no significant functional changes, just reorganisation
makes it a little easier to run 'npm run dev' and 'npm run build' for testing, which will always default to testnet; mainnet builds are not normally used informally
cli differs from other apps in that we use long lines extensively in repl output, so the rule is very restrictive and has forced weird workarounds to keep linter warnings at 0. disabling this and using IDE word-wrap instead makes it more approachable, particularly for upcoming repl changes
this simplifies printing of multi-line text and newline handling, including automatic indentation stripping
adamkdean
approved these changes
Dec 21, 2022
| @@ -0,0 +1,39 @@ | |||
| // Copyright (C) 2021 Edge Network Technologies Limited | |||
| @@ -0,0 +1,53 @@ | |||
| // Copyright (C) 2021 Edge Network Technologies Limited | |||
| @@ -0,0 +1,22 @@ | |||
| // Copyright (C) 2021 Edge Network Technologies Limited | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge CLI v1.8.1 is the first minor version increment since March, and includes a slew of improvements.
The entire codebase has been reviewed, reorganised and refactored to improve maintainability. CLI commands are now located in individual files, rather than collected by domain. CLI options are now defined consistently across the command tree in a single
clinamespace, reducing overlapping imports. A newreplnamespace has been established which includes preexisting input handlers and adds new printing functions, simplifying text display (and coding thereof) across all commands. Themax-lenESLint rule has been disabled to eliminate the need for awkward style workarounds. As well as making it easier for Edge core engineers to improve CLI, we continue to encourage community contributions and hope these updates will make the code more approachable. Your feedback is very welcome on Discord or in issues/PRs.The following existing issues have been resolved:
edge stake lsnow supports filters: pass-t (stargate|gateway|host)to filter by stake type, or-s (assigned|released|unassigned|unlocked|unlocking)to filter by status. These filters can also be used together.edge device addnow supports adding a device to a stake by type rather than needing to specify the ID. For example,edge device add -t hostwill automatically select an unassigned Host stake if one is available.Finally, some dependencies have been updated and npm audit issues have been resolved.