Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI to search signed agreements, completes auth for administrators #18

Merged
merged 12 commits into from
Jun 6, 2020

Conversation

RobertoPrevato
Copy link
Contributor

Authentication for administrators work by integration with GitHub sign-in, using the same OAuth application used for contributors. CLA-bot verifies that the user who signed in is indeed an administrator, and issues a JWT. The client side verifies that an access token exists before rendering the admin UI.
APIs that manipulate information in the database require JWT Bearer Authorization header. GET methods that return read-only public information, such as agreements list and texts, are still public (they don't require an access token).

Added several other improvements to the existing code. For example, possibility to display dates in EN-GB format instead of EN-US format.

@RobertoPrevato RobertoPrevato merged commit b79c9d9 into master Jun 6, 2020
@RobertoPrevato RobertoPrevato deleted the admin-clas branch June 7, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement admin UI to see signed CLAs Complete authentication and authorization strategies
1 participant