-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support array input parameters #714
Comments
Would question this being |
There is one potential actual UI design question, which is how to syntactically represent arrays of |
I don't expect that I have time for this in 3.0 timeframe. This might be introduced in 3.x cycle.
For testing queries, I've expected something along the lines of:
But if people use arrays in REPL a lot, it will not be very convenient. Also I wanted to be able to switch between input modes via a keyboard shortcut. But |
One difficulty with the multi-entry approach is that if we have |
This PR reworks the variable input mechanism to use nom as a parser; allowing us to parse array inputs and other complex inputs. Arrays and tuples are parsed using edgeql syntactic conventions. Inside of arrays and tuples, strings must be quoted using edgeql conventions. A good follow-up might be to support parsing things like uuids as `<uuid>'acb53d04-184e-11ef-aaab-cb2f1138c5d7'` and similar, as well as using more abbreviated syntax. Fixes #714 --------- Co-authored-by: Michael J. Sullivan <sully@msully.net>
Occurs to me on another reading that "minor" might have referred to implementation difficulty! Sorry for the presumptuous comment |
No, your interpretation was right as was (in my opinion at least) your disagreement with tagging it "minor". |
If I try to specify an array input param in the CLI, I get
The text was updated successfully, but these errors were encountered: