Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi range support #290

Merged
merged 16 commits into from
Apr 10, 2024
Merged

Add multi range support #290

merged 16 commits into from
Apr 10, 2024

Conversation

diksipav
Copy link
Contributor

Update descriptors.
Add multirange codec.
Add simple multi range test.

NOTE: I'll add more and better tests.

Update descriptors.
Add multirange codec.
Add simple multi range test.
@diksipav diksipav requested a review from nsidnev October 25, 2023 21:05
internal/codecs/codecs.go Outdated Show resolved Hide resolved
internal/descriptor/descriptor_v2.go Outdated Show resolved Hide resolved
internal/client/types_test.go Outdated Show resolved Hide resolved
@diksipav diksipav marked this pull request as ready for review November 10, 2023 15:17
Copy link
Member

@fmoor fmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

internal/client/types_test.go Outdated Show resolved Hide resolved
internal/edgedbtypes/multirange.go Outdated Show resolved Hide resolved
@fmoor
Copy link
Member

fmoor commented Feb 13, 2024

@diksipav how is this going? Is this waiting on a review?

@diksipav diksipav merged commit bdef9e4 into master Apr 10, 2024
9 checks passed
@diksipav diksipav deleted the 286-add-multirange-support branch April 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants