-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience functions to transform between edgedb.Duration and time.Duration #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to this so quickly! Its been a while so I'm remembering a few more details as I look at this again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One last detail I forgot about.
Any last changes before I merge? |
Nothing comes to mind, looks like it is ready 🚀 |
released in |
This is meant to improve usability of
Duration
values and better integrate with the Go ecosystem.This also makes the unit (micro/nanoseconds) difference between
Duration
andtime.Duration
more obvious, hopefully reducing the likelihood of introducing hard to detect bugs such as: