Replace tslint with typescript-eslint #1030
Conversation
diksipav
force-pushed
the
go-back-when-tests-work
branch
from
f7c099e
to
ced2695
Compare
eslint.config.mjs
Outdated
| // We need to use the tseslint.configs.stylistic, but some stylistic rules are erroring. | ||
| // These 4 pass. We can gradually add the rest and at the end replace with the tseslint config. |
There was a problem hiding this comment.
I have an idea here:
What if we added the tseslint.configs.stylistic rule here but change any rules that are currently breaking to warn so we can notice them when we're working on a file that might contain a rule violation so maybe we can fix it while we're working on some related code?
There was a problem hiding this comment.
oh, I am not completely sure what exactly is breaking (except for one rule), alos there are hundreds of changes and only some of them is making a problem... but yes, I can do that, just wanted to finish asap : )
There was a problem hiding this comment.
and I mean this can be tracked down, just I need maybe 2 more h...
There was a problem hiding this comment.
Don't sweat it for now, these rules are already beyond what we had in tslint, so I'm not super worried.
There was a problem hiding this comment.
3 rules at the end make problems... I will return to this when I get more time, I turned them off for now because lint:fix will automatically fix them (and we don't want them, because that will result in an err). Will research if lint:fix can fix only errors and not warning.
diksipav
changed the title
No description provided.