Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support #117

Merged
merged 5 commits into from
Jul 26, 2021
Merged

Add TLS support #117

merged 5 commits into from
Jul 26, 2021

Conversation

fmoor
Copy link
Member

@fmoor fmoor commented Jul 9, 2021 •
edited by fantix

Deno ALPN support is tracked at denoland/deno#11479

jaclarke
jaclarke reviewed Jul 12, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
@fmoor fmoor force-pushed the tls branch 14 times, most recently from 14572d7 to 71d0766 Compare July 16, 2021 17:08
1st1
1st1 reviewed Jul 19, 2021
View reviewed changes
src/con_utils.ts Outdated Show resolved Hide resolved
fmoor added a commit that referenced this pull request Jul 19, 2021
@fmoor
remove in operator usages
b466f1d 
see #117 (comment)
@fmoor fmoor mentioned this pull request Jul 19, 2021
Merged
fmoor added a commit that referenced this pull request Jul 19, 2021
@fmoor
remove in operator usages
4eec4f8 
see #117 (comment)
fmoor added a commit that referenced this pull request Jul 19, 2021
@fmoor
remove in operator usages (#119)
939e031 
see #117 (comment)
@fmoor fmoor force-pushed the tls branch 3 times, most recently from 6df1a32 to fadcee8 Compare July 20, 2021 21:53
@fmoor fmoor marked this pull request as ready for review July 22, 2021 11:52
@fmoor fmoor force-pushed the tls branch 2 times, most recently from a3ac78f to 7977366 Compare July 22, 2021 17:55
fmoor
fmoor commented Jul 22, 2021
View reviewed changes
src/client.ts Show resolved Hide resolved
@fmoor fmoor requested review from 1st1 and jaclarke July 22, 2021 18:18
fantix
fantix approved these changes Jul 22, 2021
View reviewed changes
src/con_utils.ts Outdated Show resolved Hide resolved
src/credentials.ts Outdated Show resolved Hide resolved
@fmoor fmoor force-pushed the tls branch 2 times, most recently from 8aacfd7 to de930db Compare July 26, 2021 14:23
jaclarke
jaclarke reviewed Jul 26, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
1st1
1st1 reviewed Jul 26, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
1st1
1st1 reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, but the version comparison code needs to be simplified.

1st1
1st1 reviewed Jul 26, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
1st1
1st1 approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please squash before merging

@fmoor fmoor merged commit d776124 into master Jul 26, 2021
@fmoor fmoor deleted the tls branch July 26, 2021 21:20
@fmoor fmoor mentioned this pull request Jul 30, 2021
Closed
renawolford6 added a commit to renawolford6/edg-edb-javascript that referenced this pull request Nov 10, 2022
@renawolford6
remove in operator usages (#119)
ebee662 
see edgedb/edgedb-js#117 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

@jaclarke jaclarke jaclarke left review comments

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fmoor @1st1 @fantix @jaclarke