Add .runJSON to query builder expressions
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Mar 26, 2022
| ? this | ||
| : wrappedExprCache.get(this) ?? | ||
| wrappedExprCache.set(this, select(this)).get(this); | ||
| const _args = jsonifyComplexParams(expr, args); |
There was a problem hiding this comment.
Hm, what's this btw? Why are we "jsonifying" arguments?
There was a problem hiding this comment.
We allow more complex parameter types and implicitly convert them to JSON on both ends: https://www.edgedb.com/docs/clients/01_js/parameters#complex-types This makes it possible to accept more complex data structures in query.run(client, parameters) to support an end-to-end typesafe workflow where you take a JSON payload, validate it with a schema library, and pass it in the params object, and type safety is enforced at every step along the way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.