Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docs and fix number to string #317

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

nicu-chiciuc
Copy link
Contributor

I was reading the docs and I wanted to fix

  const q1 = await e.str("Hello world!").run(client);
  // number

since the inferred type is actually the string literal "Hello world!". But I thought that writing "Hello world!" instead of number seems confusing. So I thought that maybe using an addition so that the inferred type is string is a better idea.

Also I've added run() at the end of the code since I was expecting the code to run something by itself without me having to write run() afterwards. But this is debatable so I can undone the change.

@edgedb-cla
Copy link

edgedb-cla bot commented Mar 27, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@colinhacks colinhacks merged commit 69b9e45 into edgedb:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants