Implement credentials_file support #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tailhook
force-pushed
the
credentials_file
branch
4 times, most recently
from
a752658
to
60294d4
Compare
1st1
reviewed
Aug 14, 2020
tailhook
force-pushed
the
credentials_file
branch
2 times, most recently
from
f010628
to
3550391
Compare
Also deprecate `admin: true` and `edgedbadmin:` protocol, as they aren't needed if proper permissions are set up. And was introduced mainly for command-line tools.
tailhook
force-pushed
the
credentials_file
branch
from
3550391
to
7ac38f4
Compare
tailhook
commented
Aug 17, 2020
| @@ -280,6 +280,9 @@ function parseConnectDsnAndArgs({ | |||
| } else { | |||
| host = ["/run/edgedb", "/var/run/edgedb"]; | |||
| } | |||
| if (!admin) { | |||
There was a problem hiding this comment.
@1st1 this is how respective code in python looks like. Was this omission intentional?
|
I'll take another look once edgedb/edgedb-rust#45 is settled. |
|
Superseded by #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecate
admin: trueandedgedbadmin:protocol, asthey aren't needed if proper permissions are set up. And was introduced
mainly for command-line tools.