Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use browser crypto for SCRAM #988

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Use browser crypto for SCRAM #988

wants to merge 9 commits into from

Commits on May 1, 2024

  1. Use browser crypto for SCRAM 

    Since all supported platforms support browser-compatible crypto, remove
the extraneous adapters and standardize on the browser API. This
requires a flag for Node v18 to enable the browser global
`--experimental-global-webcrypto`, but this is already required by a few
other libraries in our ecosystem.
    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    07f9c0c View commit details
    Browse the repository at this point in the history

  2. Add note about Node 18 requirement to README 

    Node 18 hides the `crypto` global behind a flag, so make note of that in
the main README.
    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c4673e0 View commit details
    Browse the repository at this point in the history

  3. Remove extra factory around connectWithTimeout

    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bba3a81 View commit details
    Browse the repository at this point in the history

  4. Prettier

    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    44c8f75 View commit details
    Browse the repository at this point in the history

  5. Use required CLI flag 

    Since our CI still runs on Node 18, ensure we run with this flag on
which is a no-op for newer versions
    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0ca3a8e View commit details
    Browse the repository at this point in the history

  6. Cannot set NODE_OPTIONS in GITHUB_ENV 

    There is some security reason we are specifically not allowed to set
NODE_OPTIONS in GITHUB_ENV.
    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cbc15e2 View commit details
    Browse the repository at this point in the history

  7. More steps need this NODE_OPTION set

    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    bdaf7c1 View commit details
    Browse the repository at this point in the history

  8. Try to remove experimental-vm-modules flag 

    Is this needed still?
    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    627eeef View commit details
    Browse the repository at this point in the history

  9. Be more clear about which versions require flag

    @scotttrinh
    scotttrinh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e4d7ffe View commit details
    Browse the repository at this point in the history