-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for hard-to-detect recursive CLI calls #996
Merged
Merged
Commits on May 3, 2024
-
Test for hard-to-detect recursive CLI calls
Yarn Berry uses an even different scheme for running bin scripts: it unpacks the script into a temporary directory and adds that temporary directory into the shell's environment. This mitigate is by far the most expensive, so it's used dead-last to avoid the overhead. Looks like on yarn 4.1.1, the call that succeeds takes an additional 140ms, so that calling latency is added to every call of the package bin script here.
Configuration menu - View commit details
-
Copy full SHA for 7525d50 - Browse repository at this point
Copy the full SHA 7525d50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7988924 - Browse repository at this point
Copy the full SHA 7988924View commit details -
Update cache if successful binary was not cached
In the case of the cache being empty, or it pointing to a wrapper script, make sure we update the cache after we get a successful run from the CLI. This will not cache the location if the run failed, which could be common, but seems safer than always caching.
Configuration menu - View commit details
-
Copy full SHA for 5b1eb4f - Browse repository at this point
Copy the full SHA 5b1eb4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e462883 - Browse repository at this point
Copy the full SHA e462883View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1336891 - Browse repository at this point
Copy the full SHA 1336891View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed9bae5 - Browse repository at this point
Copy the full SHA ed9bae5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06b9e35 - Browse repository at this point
Copy the full SHA 06b9e35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16bf4db - Browse repository at this point
Copy the full SHA 16bf4dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b66b98 - Browse repository at this point
Copy the full SHA 4b66b98View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5f30e5 - Browse repository at this point
Copy the full SHA d5f30e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d158b27 - Browse repository at this point
Copy the full SHA d158b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for b90c414 - Browse repository at this point
Copy the full SHA b90c414View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41c61db - Browse repository at this point
Copy the full SHA 41c61dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c0da9f - Browse repository at this point
Copy the full SHA 7c0da9fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.