Don't reject tuple arguments on the client side

Right now we reject them on the server side. If that is fixed, they work fine on the client.
edgedb · Oct 6, 2022 · 69198d7 · 69198d7
1 parent e24bb53
commit 69198d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/edgedb/protocol/codecs/array.pyx b/edgedb/protocol/codecs/array.pyx
@@ -37,7 +37,10 @@ cdef class BaseArrayCodec(BaseCodec):
             Py_ssize_t objlen
             Py_ssize_t i
 
-        if not isinstance(self.sub_codec, (ScalarCodec, TupleCodec, RangeCodec)):
+        if not isinstance(
+            self.sub_codec,
+            (ScalarCodec, TupleCodec, NamedTupleCodec, RangeCodec)
+        ):
             raise TypeError(
                 'only arrays of scalars are supported (got type {!r})'.format(
                     type(self.sub_codec).__name__

diff --git a/edgedb/protocol/codecs/base.pyx b/edgedb/protocol/codecs/base.pyx
@@ -132,15 +132,16 @@ cdef class BaseRecordCodec(BaseCodec):
             for codec in self.fields_codecs:
                 if not isinstance(
                     codec,
-                    (ScalarCodec, ArrayCodec, EnumCodec, RangeCodec),
+                    (ScalarCodec, ArrayCodec, TupleCodec, NamedTupleCodec,
+                     EnumCodec, RangeCodec),
                 ):
                     self.encoder_flags |= RECORD_ENCODER_INVALID
                     break
             self.encoder_flags |= RECORD_ENCODER_CHECKED
 
         if self.encoder_flags & RECORD_ENCODER_INVALID:
             raise TypeError(
-                'argument tuples only support scalars and arrays of scalars')
+                'argument tuples do not support objects')
 
     cdef encode(self, WriteBuffer buf, object obj):
         cdef: