Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include __all__ in top level __init__.py #301

Closed
johnrezk opened this issue Apr 11, 2022 · 1 comment · Fixed by #364
Closed

Include __all__ in top level __init__.py #301

johnrezk opened this issue Apr 11, 2022 · 1 comment · Fixed by #364

Comments

@johnrezk
Copy link

Pylance, the most commonly used Python language server for VS Code, currently displays errors when attempting to access any objects imported in the top level ___init___.py of the edgedb module.

image

This appears to be due to pylance's distinction between private and public symbols via __all__

In a brief test, I created an __all__ set with public symbols and pylance no longer reported an error.

Considering the ubiquity of VS Code and pylance, it may be a good idea to conform to their standards and include an __all__.
@1st1
Copy link
Member

1st1 commented Apr 11, 2022

Sure, we can add it. Do you want to submit a PR?

fmoor added a commit that referenced this issue Sep 7, 2022
@fmoor
Add __all__ to edgedb/__init__.py
31d67d3 
fixes #301
@fmoor fmoor mentioned this issue Sep 7, 2022
Merged
fantix pushed a commit that referenced this issue Oct 21, 2022
@fmoor @fantix
Add __all__ to edgedb/__init__.py
d3ef6d9 
fixes #301
fantix added a commit that referenced this issue Oct 21, 2022
@fmoor @fantix
Add __all__ to edgedb/__init__.py (#364)
78465e1 
* Add __all__ to edgedb/__init__.py

fixes #301

Co-authored-by: Fantix King <fantix.king@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add __all__ to edgedb/__init__.py edgedb/edgedb-python
2 participants
@1st1 @johnrezk