Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings get confused if a linkprop and a regular prop have the same name #377

Closed
msullivan opened this issue Oct 12, 2022 · 1 comment · Fixed by #384
Closed

Bindings get confused if a linkprop and a regular prop have the same name #377

msullivan opened this issue Oct 12, 2022 · 1 comment · Fixed by #384
Labels
bug Something isn't working high priority

Comments

@msullivan
Copy link
Member

If you do something like this (on the cards test db)

v = db.query('''
    select User { deck: {@count, count := 10} }
''')

then v[0].deck[0].count will produce

'edgedb.Object' object has no attribute 'count'
@msullivan msullivan added the bug Something isn't working label Oct 12, 2022
@fantix
Copy link
Member

fantix commented Oct 21, 2022

#379 didn't fix this - because the key in RecordDesc is overwritten by another. The right fix would be to prefix the key of link properties in RecordDesc directly. I'll create a PR soon.

fantix added a commit that referenced this issue Oct 21, 2022
Changes
=======

* Implement dataclass for EdgeObject (#359)
  (by @fantix in dfb8c8b for #359)

* Redo edgedb basic types to inherit from builtin types (#366)
  (by @fantix in b11b991 for #366)

* Officially drop 3.6 support (#373)
  (by @msullivan in 7b76bc7 for #373)

* Support Python 3.11 (#375)
  (by @msullivan in 04b0da2 for #375)

* Codegen with the describe_query() API (#363)
  (by @fantix in 361221d for #363)

* Add codegen docs (#380)
  (by @colinhacks in 23dd42e for #380)

* Use typing_extension.Literal in codegen for Python 3.7
  (by @fantix in 6d0d6ab)

* Add __all__ to edgedb/__init__.py
  (by @fmoor in d3ef6d9)

Fixes
=====

* Improve duration parsing
  (by @fmoor in 241c80d)

* Tweak wording in query_single() error messages (#369)
  (by @msullivan in e24bb53 for #369)

* Fix flake tests on python3.7 (#371)
  (by @msullivan in 583e1cb for #371)

* Don't reject tuple arguments on the client side (#370)
  (by @msullivan in 09c950f for #370)

* Correct edgedb.Client.close() timeout behavior
  (by @fantix in 33a912c)

* Ping first if conn is idle for too long (#365)
  (by @fantix in 99cf78a for #365)

* Use @-prefixed keys in object codec for link properties (#384)
  (by @fantix in 68480f9 for #377)

Deprecations
============

* Deprecate object links and simplify link property access (#379)
  (by @fantix in 2c5dcc7 for #379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants