Add accept header in GitHub code exchange (#6206)

edgedb · Oct 3, 2023 · 2425582 · 2425582
1 parent 7dde356
commit 2425582
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/edb/server/protocol/auth_ext/github.py b/edb/server/protocol/auth_ext/github.py
@@ -20,7 +20,7 @@
 import urllib.parse
 import functools
 
-from . import base, data
+from . import base, data, errors
 
 
 class GitHubProvider(base.BaseProvider):
@@ -58,7 +58,14 @@ async def exchange_code(
                     "client_secret": self.client_secret,
                     "redirect_uri": redirect_uri,
                 },
+                headers={
+                    "accept": "application/json",
+                }
             )
+            if resp.status_code >= 400:
+                raise errors.OAuthProviderFailure(
+                    f"Failed to exchange code: {resp.text}"
+                )
             json = resp.json()
 
             return data.OAuthAccessTokenResponse(**json)