Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-line fixes #1039

Merged
merged 6 commits into from
Jan 6, 2020
Merged

Command-line fixes #1039

merged 6 commits into from
Jan 6, 2020

Conversation

tailhook
Copy link
Contributor

@tailhook tailhook commented Jan 6, 2020

Fixes #1029, #1030

I've left configure as is, but if we want to make it a form similar to other (verb-noun) they should have been insert-config/reset-config/set-config, which I'm not sure are good. Anyway, current configure is good for discoverability.

@tailhook tailhook mentioned this pull request Jan 6, 2020
76 tasks
Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the documentation accordingly.

@tailhook
Copy link
Contributor Author

tailhook commented Jan 6, 2020

Right, sorry. Also, i've just noticed:

  -P, --postgres-dsn TEXT         DSN of a remote Postgres cluster, if using
  -I, --bind-address TEXT         IP address to listen on
  -P, --port INTEGER              port to listen on

(not sure why click doesn't check for that!)
Which -P is right here? I would probably drop short alias for --postgres-dsn at all, I don't see a reason for it to be short (so we keep symmetry in client and server, an also both -I and -P are upper case).

@tailhook
Copy link
Contributor Author

tailhook commented Jan 6, 2020

Updated docs and also dropped -P alias for --postgres-dsn. Let me know if you think it's needed.

@1st1
Copy link
Member

1st1 commented Jan 6, 2020

I would probably drop short alias for --postgres-dsn

+1. We should only use one letter aliases for commonly used parameters anyways.

@1st1
Copy link
Member

1st1 commented Jan 6, 2020

(not sure why click doesn't check for that!)

That's quite scary actually.

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tailhook tailhook merged commit 6aac2e3 into master Jan 6, 2020
tailhook added a commit to edgedb/edgedb-rust that referenced this pull request Jan 8, 2020
@1st1 1st1 deleted the command_line branch January 8, 2020 21:03
tailhook added a commit to edgedb/edgedb-rust that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommands in edgedb-repl
3 participants