Fix several issues that manifest when using GROUP BY #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
approved these changes
Oct 18, 2022
msullivan
force-pushed
the
group-trouble
branch
from
e533d29
to
34244da
Compare
It is common to hit materialization when using GROUP BY. This fixes a cluster of them. 1. When looking for a materialized pointer inside a source rvar grabbing a pointer, discard any namespaces that are not on the source path. unpack_rvar won't put those namespaces on the path, so we can't either. 2. Explicitly track the binding scope for visibility materialization, and use that when checking for visibility. Fixes #3951. Fixes #4240. Fixes #4481. Issues #3951 and #4240 depend on fix 1, #4481 depends on fix 2. Fix 2 also fixed two existing xerrored tests and turns one of the worst remaining miscompiles into an ISE.
msullivan
force-pushed
the
group-trouble
branch
from
34244da
to
4010b36
Compare
msullivan
added a commit
that referenced
this pull request
Oct 20, 2022
It is common to hit materialization bugs when using GROUP BY. This fixes a cluster of them. 1. When looking for a materialized pointer inside a source rvar grabbing a pointer, discard any namespaces that are not on the source path. unpack_rvar won't put those namespaces on the path, so we can't either. 2. Explicitly track the binding scope for visibility materialization, and use that when checking for visibility. Fixes #3951. Fixes #4240. Fixes #4481. Issues #3951 and #4240 depend on fix 1, #4481 depends on fix 2. Fix 2 also fixed two existing xerrored tests and turns one of the worst remaining miscompiles into an ISE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common to hit materialization when using GROUP BY. This fixes a
cluster of them.
grabbing a pointer, discard any namespaces that are not on the source
path. unpack_rvar won't put those namespaces on the path, so we can't
either.
and use that when checking for visibility.
Fixes #3951. Fixes #4240. Fixes #4481.
Issues #3951 and #4240 depend on fix 1, #4481 depends on fix 2. Fix 2
also fixed two existing xerrored tests and turns one of the worst
remaining miscompiles into an ISE.