Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow partial paths in the defaults of link properties #5560

Merged
merged 12 commits into from Jun 13, 2023
Merged

Disallow partial paths in the defaults of link properties #5560

merged 12 commits into from Jun 13, 2023

Conversation

zchenb
Copy link
Contributor

@zchenb zchenb commented May 26, 2023

Fix #5200

@zchenb zchenb changed the title Disallow partial paths in defaults of link properties Disallow partial paths in the defaults of link properties May 26, 2023
@zchenb zchenb mentioned this pull request May 26, 2023
Open
@zchenb
Copy link
Contributor Author

zchenb commented May 26, 2023

With #5142, we should probably provide a hint to why the partial paths cannot be resolved. This error message is obscure. Creating an issue #5561.

@zchenb zchenb requested a review from msullivan May 26, 2023 20:03
msullivan
msullivan approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems like a solid fix, though I posted some quibbles about the exact approach

edb/schema/pointers.py Outdated Show resolved Hide resolved
@zchenb
Copy link
Contributor Author

zchenb commented Jun 8, 2023

I have made the updates. Could you please take another look @msullivan?

@elprans elprans requested a review from msullivan June 9, 2023 22:50
msullivan
msullivan approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Hope the merge conflicts aren't bad...

edb/schema/pointers.py Outdated Show resolved Hide resolved
@zchenb zchenb merged commit 958f5ea into master Jun 13, 2023
22 checks passed
@zchenb zchenb deleted the zc/default_in_link_prop_fix branch June 13, 2023 19:43
msullivan pushed a commit that referenced this pull request Jun 13, 2023
@zchenb @msullivan
Disallow partial paths in the defaults of link properties (#5560)
5677f80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error during compiled migration: QueryError: could not resolve partial path
2 participants
@zchenb @msullivan