-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the leading dot notation in inserts #5142
Conversation
The problem is that while we wanted to disallow these leading dots in the expression itself, we do now allow them in defaults |
So I am not sure whether the following would make sense: Given the schema
The following two represent potentially good insert queries:
Both queries are currently allowed. Obviously, we would like to ban queries like |
The current semantics seems to be that, all properties have defaults being the empty set unless otherwise specified. Inserts are really inserting the object after applying the insert shape to the default object. That is, |
This PR is ready for merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks.
Fixes #4958